Horton

Re: DROP OWNED BY fails to clean out pg_init_privs grants

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hannu Krosing <hannuk@google.com>, Daniel Gustafsson <daniel@yesql.se>, "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Noah Misch <nmisch@google.com>
Date: 2024-06-20T19:18:49Z
Lists: pgsql-hackers 
On Thu, Jun 20, 2024 at 2:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Hannu Krosing <hannuk@google.com> writes:
> > Or perhaps we should still also patch pg_dump to ignore the aclentries
> > which refer to roles that do not exist in the database ?
>
> I didn't want to do that before, and I still don't.  Given that this
> issue has existed since pg_init_privs was invented (9.6) without
> prior reports, I don't think it's a big enough problem in practice
> to be worth taking extraordinary actions for.

If we don't fix it in the code and we don't document it anywhere, the
next person who hits it is going to have to try to discover the fact
that there's a problem from the pgsql-hackers archives. That doesn't
seem good. I don't have an educated opinion about what we should do
here specifically, and I realize that we don't have any official place
to document known issues, but it can be pretty inconvenient for users
not to know about them.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Allow meson builds to run test_pg_dump test in installcheck mode.

  2. Remove recordExtensionInitPriv[Worker]'s ownerId argument.

  3. Improve tracking of role dependencies of pg_init_privs entries.

  4. Fix failure to track role dependencies of pg_init_privs entries.

  5. Drop global objects after completed test