Horton

Re: pg_verifybackup: TAR format backup verification

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Amul Sul <sulamul@gmail.com>
Cc: Sravan Kumar <sravanvcybage@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-09-27T12:03:44Z
Lists: pgsql-hackers 
On Fri, Sep 27, 2024 at 2:07 AM Amul Sul <sulamul@gmail.com> wrote:
> Thank you, Robert. The code changes look much better now.

Cool.

> A few minor comments:
>
> +            each tablespace, named after the tablespace's OID. If the backup
> +            is compressed, the relevant compression extension is added to the
> +            end of each file name.
>
> I am a bit unsure about the last line, especially the use of the word
> "added."  I feel like it's implying that we're adding something, which
> isn't true.

If you add .gz to the end of 16904.tar, you get 16904.tar.gz. This
seems like correct English to me.

> Typo: futher

OK, thanks.

> The addition of simple_ptr_list_destroy will be part of a separate
> commit, correct?

To me, it doesn't seem worth splitting that out into a separate commit.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Adjust json_manifest_per_file_callback API in one more place.

  2. File size in a backup manifest should use uint64, not size_t.

  3. Fix some pg_verifybackup issues reported by Coverity.

  4. pg_verifybackup: Move some declarations to new pg_verifybackup.h

  5. pg_verifybackup: Move skip_checksums into verifier_context.

  6. Improve file header comments for astramer code.

  7. Move astreamer (except astreamer_inject) to fe_utils.

  8. Move recovery injector astreamer to a separate header file.

  9. Rename bbstreamer to astreamer.