Horton

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Amit kapila <amit.kapila@huawei.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Boszormenyi Zoltan <zb@cybertec.at>, Magnus Hagander <magnus@hagander.net>, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Josh Berkus <josh@agliodbs.com>
Date: 2013-07-17T19:30:32Z
Lists: pgsql-hackers 
On Fri, Jul 12, 2013 at 9:15 AM, Amit kapila <amit.kapila@huawei.com> wrote:
> The sleep is used to ensure the effects of pg_reload_conf() can be visible.

That strikes me as almost certain to result in random regression test
failures.  My experience, as a man who helps to maintain a very large
suite of regression tests, is that all time-based assumptions about
how long it will take some operation to complete are false, and that
failures are a lot more frequent than you think they will be.

This feature doesn't strike me as a good candidate for regression
testing anyway.  Keep in mind that people are intended to be able to
run make installcheck against a deployed system without messing it up.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company