Horton

Re: HOT chain validation in verify_heapam()

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, Andres Freund <andres@anarazel.de>
Date: 2023-03-22T13:19:18Z
Lists: pgsql-hackers 
On Fri, Mar 17, 2023 at 8:31 AM Aleksander Alekseev
<aleksander@timescale.com> wrote:
> The patch needed a rebase due to a4f23f9b. PFA v12.

I have committed this after tidying up a bunch of things in the test
case file that I found too difficult to understand -- or in some cases
just incorrect, like:

     elsif ($offnum == 35)
     {
-        # set xmax to invalid transaction id.
         $tup->{t_xmin} = $in_progress_xid;
         $tup->{t_infomask} &= ~HEAP_XMIN_COMMITTED;
         push @expected,

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. amcheck: Generalize one of the recently-added update chain checks.

  2. amcheck: Tighten up validation of redirect line pointers.

  3. amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

  4. amcheck: Fix a few bugs in new update chain validation.

  5. Fix new test case to work on (some?) big-endian architectures.

  6. Don't test HEAP_XMAX_INVALID when freezing xmax.