Re: [bug] relcache leaks in get_object_address
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-10-14T15:41:25Z
Lists: pgsql-hackers
On Thu, Oct 13, 2011 at 12:27 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote: > The attached patch fixes this problem. > Unfortunately, we have no code that invokes get_object_address() > with missing_ok = true now, so please apply a couple of patches > to rework DROP statement of mine. > > DROP TRIGGER no_such_trigger ON existing_table; > > shall cause a relcache reference leaks, without this patch. We could argue that that's a bug in your drop reworks rather than the existing code, but I'm willing to go along with this approach, so, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company