Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Peter Geoghegan <peter@2ndquadrant.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, PG Hackers <pgsql-hackers@postgresql.org>

Date: 2012-02-27T04:59:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Restructure SELECT INTO's parsetree representation into CreateTableAsStmt.
- 9dbf2b7d75de 9.2.0 cited
Extend the parser location infrastructure to include a location field in
- a2794623d292 8.4.0 cited
Teach eval_const_expressions() to simplify an ArrayCoerceExpr to a constant
- 6734182c169a 8.4.0 cited

On Fri, Feb 24, 2012 at 9:43 AM, Peter Geoghegan <peter@2ndquadrant.com> wrote:
> Tom's point example does not seem to be problematic to me - the cast
> *should* blame the 42 const token, as the cast doesn't work as a
> result of its representation, which is in point of fact why the core
> system blames the Const node and not the coercion one.

I think I agree Tom's position upthread: blaming the coercion seems to
me to make more sense.  But if that's what we're trying to do, then
why does parse_coerce() say this?

        /*
         * Set up to point at the constant's text if the input routine throws
         * an error.
         */

/me is confused.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company