Re: Custom table AMs need to include heapam.h because of BulkInsertState
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-06-04T14:18:03Z
Lists: pgsql-hackers
On Sat, Jun 1, 2019 at 3:09 PM Michael Paquier <michael@paquier.xyz> wrote: > I am fine to live with the dependency with vacuum.h as it is not that > strange. However for BulkInsertState we get a hard dependency with a > heap-related area and it seems to me that we had better move that part > out of heapam.c, as we want a clear dependency cut with the heap AM > for any new custom table AM. Yeah, I noticed this, too. +1 for doing something about it. Not sure exactly what is the best approach. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Fix missing calls to table_finish_bulk_insert during COPY, take 2
- f7c830f1ab26 13.0 landed
- b8ef33b2d145 12.0 landed
-
Fix missing call to table_finish_bulk_insert during COPY
- 4de60244e2fc 12.0 landed