Horton

Re: gai_strerror() is not thread-safe on Windows

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com, pgsql-hackers@postgresql.org
Date: 2024-01-15T19:52:11Z
Lists: pgsql-hackers 
On Wed, Dec 6, 2023 at 8:45 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> > So I think we should just hard-code the error messages in English and
> > move on.  However, English is my language so perhaps I should abstain
> > and leave it to others to decide how important that is.
>
> I also think that would be a good way.

Considering this remark from Kyotaro Horiguchi, I think the
previously-posted patch could be committed.

Thomas, do you plan to do that, or are there outstanding issues here?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Fix gai_strerror() thread-safety on Windows.

  2. Update comment, generation mem contexts have a "keeper" block

  3. Remove replacement code for getaddrinfo.