Horton
Menu

Re: doc: pgevent.dll location

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: "Ryohei Takahashi (Fujitsu)" <r.takahashi_2@fujitsu.com>, Dave Page <dpage@pgadmin.org>, Gurjeet Singh <gurjeet@singh.im>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-12T16:02:53Z
Lists: pgsql-hackers 
On Wed, Nov 6, 2024 at 11:11 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> I don't have Windows handy to test it out, but looking at the respective
> build system source files, in master, pgevent is built and installed
> like a normal shared library in both meson.build and Makefile, so it
> should end up somewhere in lib.
>
> In src/tools/msvc in REL_16_STABLE, I see some code that appears to
> suggest that it installs in bin.
>
> Again, this is just reading the code, but it seems to be backwards from
> what is claimed earlier.
>
> The statements like "in PGxxx it did this" are not precise enough
> because there are three possible build systems.  We need to know what
> each build system is doing.  Also, the consideration of consistency
> should go in two dimensions: Consistency between versions and
> consistency between build systems.

To what three systems are you referring? I thought we now only
supported building with meson on Windows, and this is a
Windows-specific file. Everyone seems to be saying the file has moved
in v17, so it seems like we should either move it back or update the
documentation as proposed. The question of why it has moved is perhaps
worth some investigation, but seems like a secondary issue.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. meson: Build pgevent as shared_module rather than shared_library