Horton

Re: "page is not marked all-visible" warning in regression tests

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-06-07T16:23:58Z
Lists: pgsql-hackers 
On Thu, Jun 7, 2012 at 12:19 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> You could do a visibilitymap_pin outside, but I don't really see the point as
> the page is already locked. There might be some slight benefit in doing so in
> multi_insert but that would be more complicated. And of doubtful benefit.

Doesn't RelationGetBufferForTuple() already do exactly that?

>> Updated patch attached.
> Looks good.

Thanks for the review.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company