Re: Ignoring BRIN for HOT udpates seems broken
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-01T20:38:16Z
Lists: pgsql-hackers
On Sat, May 28, 2022 at 4:51 PM Tomas Vondra <tomas.vondra@enterprisedb.com> wrote: > Yeah, I think that might/should work. We could still create the HOT > chain, but we'd have to update the BRIN indexes. But that seems like a > fairly complicated change to be done this late for PG15. Yeah, I think a revert is better for now. But I agree that the basic idea seems salvageable. I think that the commit message is correct when it states that "When determining whether an index update may be skipped by using HOT, we can ignore attributes indexed only by BRIN indexes." However, that doesn't mean that we can ignore the need to update those indexes. In that regard, the commit message makes it sound like all is well, because it states that "the page range summary will be updated anyway" which reads to me like the indexes are in fact getting updated. Your example, however, seems to show that the indexes are not getting updated. -- Robert Haas EDB: http://www.enterprisedb.com
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Ignore BRIN indexes when checking for HOT updates
- 19d8e2308bc5 16.0 landed
-
Revert changes in HOT handling of BRIN indexes
- e3fcca0d0d24 15.0 landed
-
Ignore BRIN indexes when checking for HOT udpates
- 5753d4ee320b 15.0 cited