Re: BUG #18545: \dt breaks transaction, calling error when executed in SET SESSION AUTHORIZATION

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Андрей Рачицкий <therealgofman@mail.ru>, pgsql-bugs@lists.postgresql.org

Date: 2024-08-06T18:48:06Z

Lists: pgsql-bugs, pgsql-hackers

On Sun, Aug 4, 2024 at 6:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> However, what the farm found is that assign_client_encoding
> is flat-out broken.  It's ignoring the first commandment
> for GUC hooks, which is "Thy assign hooks shalt not fail".
> (If we didn't need that, there wouldn't be a separation
> between check hooks and assign hooks in the first place.)

Interesting. Looks like my mistake, dating to
10c0558ffefcd12bf1d3dc35587eba41d1ce4571. I'm honestly kind of
surprised that nobody discovered this problem for 8 years. I would
have expected it to cause more problems.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix parallel worker tracking of new catalog relfilenumbers.
- 67bab53d6442 18.0 landed
Restore relmapper state early enough in parallel workers.
- 126ec0bc76d0 18.0 landed
Allow parallel workers to cope with a newly-created session user ID.
- 6e086fa2e771 18.0 landed
- f5f30c22ed69 18.0 landed
- 97380d4803d1 14.13 landed
- 849326e49a5d 16.4 landed
- 68855c03878c 12.20 landed
- 5887dd4894db 17.0 landed
- 48536305370a 15.8 landed
- 216201027d90 13.16 landed
Clean up handling of client_encoding GUC in parallel workers.
- 0ae5b763ea0e 18.0 landed
Fix rd_firstRelfilenodeSubid for nailed relations, in parallel workers.
- fe4d022c8e17 14.0 cited
Fix several mistakes around parallel workers and client_encoding.
- 10c0558ffefc 9.6.0 cited