Re: Patch (2): Implement failover on libpq connect level.
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Korry Douglas <korry.douglas@enterprisedb.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2015-10-24T11:55:59Z
Lists: pgsql-hackers
On Fri, Oct 23, 2015 at 4:02 PM, Korry Douglas <korry.douglas@enterprisedb.com> wrote: > When you call pg_is_in_recovery(), you should schema-qualify the function > name, just in case some other version of that function exists in the > search_path. I wonder whether it's really a good idea to put this kind of logic into libpq at all. I think there was some previous votes against doing so, and I tend to agree with that viewpoint. Shouldn't probing for the state of the connection be the caller's job, not libpq's? If somebody wants to write a wrapper function around this that runs this query after connecting - or any other query - they can do so. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
libpq: Add target_session_attrs parameter.
- 721f7bd3cbcc 10.0 landed
-
Remove superuser checks in pgstattuple
- fd321a1dfd64 10.0 cited
-
Fix unwanted flushing of libpq's input buffer when socket EOF is seen.
- c405918858c0 9.6.0 cited