Horton

Re: pgsql: Remove the restriction that the relmap must be 512 bytes.

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>, pgsql-committers <pgsql-committers@lists.postgresql.org>
Date: 2022-07-27T15:20:46Z
Lists: pgsql-hackers 
On Wed, Jul 27, 2022 at 6:25 AM Michael Paquier <michael@paquier.xyz> wrote:
> Right.  The whole write_relmap_file() already happens while taking
> RelationMappingLock, so that seems like a good idea for consistency at
> the end (even if I remember that there is a patch floating around to
> improve the concurrency of pgrename, which may become an easier move
> now that we require Windows 10).
>
> I have tested three runs and that was working here even if the
> issue is sporadic, so more runs may be better to have more
> confidence.

OK, I committed Thomas's patch, after taking the liberty of adding an
explanatory comment.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  2. Fix read_relmap_file() concurrency on Windows.

  3. Remove the restriction that the relmap must be 512 bytes.