Horton

Re: Have pg_basebackup write "dbname" in "primary_conninfo"?

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-02-20T11:06:09Z
Lists: pgsql-hackers 
On Tue, Feb 20, 2024 at 4:18 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
> I found an inconsistency. When I ran ` pg_basebackup -D data_N2 -U postgres -R`,
> dbname would be set as username.
>
> ```
> primary_conninfo = 'user=postgres ... dbname=postgres
> ```
>
> However, when I ran `pg_basebackup -D data_N2 -d "user=postgres" -R`,
> dbname would be set as "replication". Is it an intentional item?
>
> ```
> primary_conninfo = 'user=postgres ... dbname=replication...
> ```

Seems weird to me. You don't use dbname=replication to ask for a
replication connection, so why would we ever end up with that
anywhere? And especially in only one of two such closely related
cases?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Allow dbname to be written as part of connstring via pg_basebackup's -R option.

  2. Allow dbname in pg_basebackup/pg_receivewal connstring