Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kohei KaiGai <kaigai@kaigai.gr.jp>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-11-17T19:25:03Z
Lists: pgsql-hackers
On Thu, Nov 17, 2011 at 1:00 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> It also eliminates the NOTICE when removing a built-in
>> function, which I think is OK because you don't actually get that far:
>
> There are paths that can reach that notice --- I think what you have to
> do is create a new function that references a built-in one.  But why
> we bother to warn for that isn't clear to me.
>
>> - For some reason, we have code that causes procedural language names
>> to be downcased before use.
>
> I think this is a hangover from the fact that CREATE FUNCTION's LANGUAGE
> clause used to insist on the language name being a string literal, and
> of course the lexer didn't case-fold it then.  That's been deprecated
> for long enough that we probably don't need to have the extra case-fold
> step anymore.

OK, great.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company