Re: recovering from "found xmin ... from before relfrozenxid ..."
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-07-14T00:41:22Z
Lists: pgsql-hackers
On Mon, Jul 13, 2020 at 6:15 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > Yeah, I don't care for that either. That's a pretty huge violation of our > normal back-patching rules, and I'm not convinced that it's justified. I think that our normal back-patching rules are based primarily on the risk of breaking things, and a new contrib module carries a pretty negligible risk of breaking anything that works today. I wouldn't propose to back-patch something on those grounds just as a way of delivering a new feature more quickly, but that's not the intention here. At least in my experience, un-VACUUM-able tables have gotten several orders of magnitude more common since Andres put those changes in. As far as I can recall, EDB has not had this many instances of different customers reporting the same problem since the 9.3-era multixact issues. So far, this does not rise to that level, but it is by no means a negligible issue, either. I believe it deserves to be taken quite seriously, especially because the existing options for helping customers with this kind of problem are so limited. Now, if this goes into v14, we can certainly stick it up on github, or put it out there in some other way for users to download, self-compile, and install, but that seems noticeably less convenient for people who need it, and I'm not clear what the benefit to the project is. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Fix wrong data table horizon computation during backend startup.
- 1c7675a7a426 14.0 landed
-
Centralize horizon determination for temp tables, fixing bug due to skew.
- 94bc27b57680 14.0 landed
-
pg_surgery: Try to stabilize regression tests.
- 0811f766fd74 14.0 landed
-
New contrib module, pg_surgery, with heap surgery functions.
- 34a947ca13e5 14.0 landed
-
Set cutoff xmin more aggressively when vacuuming a temporary table.
- a7212be8b9e0 14.0 cited
-
snapshot scalability: Don't compute global horizons while building snapshots.
- dc7420c2c927 14.0 cited
-
Introduce vacuum errcontext to display additional information.
- b61d161c1463 13.0 cited