Horton

Re: tablespace_map code cleanup

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-05-27T11:57:38Z
Lists: pgsql-hackers 
On Wed, May 13, 2020 at 10:43 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> About 0002,
>
> +                               bool    sendtblspclinks = true;
>
> The boolean seems to me useless since it is always the inverse of
> opt->sendtblspcmapfile when it is used.

Well, I think it might have some documentation value, to clarify that
whether or not we send tablespace links is the opposite of whether we
send the tablespace map file.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Minor code cleanup for perform_base_backup().

  2. Don't export basebackup.c's sendTablespace().

  3. Map basebackup tablespaces using a tablespace_map file