Re: Removing GlobalVisTestNonRemovableHorizon

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Michael Paquier <michael@paquier.xyz>, Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2024-04-15T19:13:51Z
Lists: pgsql-hackers
On Mon, Apr 15, 2024 at 2:57 PM Andres Freund <andres@anarazel.de> wrote:
> GlobalVisTestNonRemovableHorizon()/GlobalVisTestNonRemovableFullHorizon() only
> existed for snapshot_too_old - but that was removed in f691f5b80a8.  I'm
> inclined to think we should remove those functions for 17.  No new code should
> use them.

+1 for removing whatever people shouldn't be using. I recently spent a
lot of time looking at this code and it's quite complicated and hard
to understand. It would of course have been nice to have done this
sooner, but I don't think waiting for next release cycle will make
anything better.

-- 
Robert Haas
EDB: http://www.enterprisedb.com



Commits

  1. Remove GlobalVisTestNonRemovable[Full]Horizon, not used anymore