Re: monitoring usage count distribution
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, schneider@ardentperf.com
Date: 2023-04-05T19:00:20Z
Lists: pgsql-hackers
On Wed, Apr 5, 2023 at 1:51 PM Nathan Bossart <nathandbossart@gmail.com> wrote: > On Wed, Apr 05, 2023 at 09:44:58AM -0400, Robert Haas wrote: > > On Tue, Apr 4, 2023 at 7:29 PM Andres Freund <andres@anarazel.de> wrote: > >> > Replacing that with a six-element integer array would be a clear improvement > >> > and, IMHO, better than adding yet another function to the extension. > >> > >> I'd have no issue with that. > > > > Cool. > > The six-element array approach won't show the number of dirty and pinned > buffers for each usage count, but I'm not sure that's a deal-breaker. > Barring objections, I'll post an updated patch shortly with that approach. Right, well, I would personally be OK with 6 rows too, but I don't know what other people want. I think either this or that is better than average. -- Robert Haas EDB: http://www.enterprisedb.com
Commits
-
Add pg_buffercache_usage_counts() to contrib/pg_buffercache.
- f3fa31327ecb 16.0 landed