Horton

Re: Removing #include "postgres.h" from a couple of headers

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-08T13:25:27Z
Lists: pgsql-hackers 
On Wed, Mar 8, 2017 at 3:55 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> Over in another thread it was pointed out that a patch I submitted
> broke a project rule by including "postgres.h" in a header.  Here is a
> patch to remove it from dsa.h where I made the same mistake, and also
> a case I found in bufmask.h by grepping.

Committed.

> There are also instances in regcustom.h and snowball's header.h -- are
> those special cases?

I will leave this question to someone wiser (or more self-assured) than I.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Fix inclusions of c.h from .h files.

  2. Fix inclusions of postgres_fe.h from .h files.

  3. Bring plpgsql into line with header inclusion policy.

  4. Document intentional violations of header inclusion policy.

  5. Remove inclusion of postgres.h from a few header files.