Re: [sepgsql 2/3] Add db_schema:search permission checks
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Kohei KaiGai <kaigai@kaigai.gr.jp>,
PgHacker <pgsql-hackers@postgresql.org>
Date: 2013-04-12T14:45:19Z
Lists: pgsql-hackers
On Fri, Apr 12, 2013 at 10:42 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Robert Haas escribió: >> On Mon, Apr 8, 2013 at 12:28 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote: > >> > Also, the attached function-execute-permission patch is a rebased >> > version. I rethought its event name should be OAT_FUNCTION_EXECUTE, >> > rather than OAT_FUNCTION_EXEC according to the manner without >> > abbreviation. Other portion is same as previous ones. >> >> Great. This looks fine to me, committed. I also committed your >> getObjectIdentity patch, which caused some regression test output >> changes. I applied the necessary correction before committing, I >> think, but please check. > > I think the function-execute code path is still using > getObjectDescription rather than identity. Yeah, I think so. KaiGai, can you provide a follow-on patch to fix that? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company