Horton

Re: [HACKERS] max_worker_processes on the standby

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Petr Jelinek <petr@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>, oonishitk@nttdata.co.jp, pgsql-docs <pgsql-docs@postgresql.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2015-10-20T13:12:24Z
Lists: pgsql-hackers, pgsql-docs 
On Sat, Oct 17, 2015 at 5:37 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
> I agree with that sentiment.
>
> Attached patch adds variable to the shmem which is used for module
> activation tracking - set to true in ActiveCommitTs() and false in
> DeactivateCommitTs(). All the checks inside the commit_ts code were changed
> to use this new variable. I also removed the static variable Alvaro added in
> previous commit because it's not needed anymore.

That sounds good to me.  On a quick read-through it looks OK too.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Cleanup commit timestamp module activaction, again

  2. Code review for transaction commit timestamps