Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Initialize variable to placate compiler.

  1. pg_plan_advice: rtekind uninitialized compilation waning

    Sami Imseih <samimseih@gmail.com> — 2026-03-12T20:16:29Z

    Hi,

I just noticed $SUBJECT due to 5883ff30b0

[1/2] Compiling C object
contrib/pg_plan_advice/pg_plan_advice.so.p/pgpa_scan.c.o
In file included from ../src/include/postgres.h:49:0,
                 from ../contrib/pg_plan_advice/pgpa_scan.c:12:
../contrib/pg_plan_advice/pgpa_scan.c: In function ‘unique_nonjoin_rtekind’:
../src/include/utils/elog.h:241:18: warning: ‘rtekind’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
  ereport(elevel, errmsg_internal(__VA_ARGS__))
                  ^~~~~~~~~~~~~~~
../contrib/pg_plan_advice/pgpa_scan.c:246:11: note: ‘rtekind’ was declared here
  RTEKind  rtekind;
           ^~~~~~~

Attached initializes rtekind to RTE_RELATION to keep the compiler happy.
The value is set correctly inside the loop before it's used.


--
Sami Imseih
Amazon Web Services (AWS)

  2. Re: pg_plan_advice: rtekind uninitialized compilation waning

    Nathan Bossart <nathandbossart@gmail.com> — 2026-03-12T21:20:14Z

    I've added Robert.

On Thu, Mar 12, 2026 at 03:16:29PM -0500, Sami Imseih wrote:
> Attached initializes rtekind to RTE_RELATION to keep the compiler happy.
> The value is set correctly inside the loop before it's used.

Looks correct to me.

-- 
nathan

  3. Re: pg_plan_advice: rtekind uninitialized compilation waning

    Nathan Bossart <nathandbossart@gmail.com> — 2026-03-13T16:32:48Z

    On Thu, Mar 12, 2026 at 04:20:14PM -0500, Nathan Bossart wrote:
> On Thu, Mar 12, 2026 at 03:16:29PM -0500, Sami Imseih wrote:
>> Attached initializes rtekind to RTE_RELATION to keep the compiler happy.
>> The value is set correctly inside the loop before it's used.
> 
> Looks correct to me.

Committed.

-- 
nathan

  4. Re: pg_plan_advice: rtekind uninitialized compilation waning

    Robert Haas <robertmhaas@gmail.com> — 2026-04-10T15:59:23Z

    On Fri, Mar 13, 2026 at 12:32 PM Nathan Bossart
<nathandbossart@gmail.com> wrote:
> On Thu, Mar 12, 2026 at 04:20:14PM -0500, Nathan Bossart wrote:
> > On Thu, Mar 12, 2026 at 03:16:29PM -0500, Sami Imseih wrote:
> >> Attached initializes rtekind to RTE_RELATION to keep the compiler happy.
> >> The value is set correctly inside the loop before it's used.
> >
> > Looks correct to me.
>
> Committed.

Thanks. Apologies for failing to notice this thread.

-- 
Robert Haas
EDB: http://www.enterprisedb.com