Horton

Re: Explain buffers wrong counter with parallel plans

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Adrien Nayrat <adrien.nayrat@anayrat.info>, Andres Freund <andres@anarazel.de>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-07-03T11:37:50Z
Lists: pgsql-hackers 
On Tue, Jul 3, 2018 at 6:48 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> Yeah, previously, I have also pointed out the same code [1].  However,
> I have not done any testing to prove it.

Ah, OK.  Sorry, forgot about that email.

> Are you planning to work on it?  If not, then I can look into it.

I won't have time for a few weeks, so if you have time sooner please have at it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Adjust comment atop ExecShutdownNode.

  2. Prohibit shutting down resources if there is a possibility of back up.

  3. Fix buffer usage stats for parallel nodes.

  4. Match the buffer usage tracking for leader and worker backends.

  5. Improve division of labor between execParallel.c and nodeGather[Merge].c.