Horton

Re: Oddity in tuple routing for foreign partitions

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-04-25T17:59:40Z
Lists: pgsql-hackers 
On Tue, Apr 24, 2018 at 10:19 PM, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> I tried to do that.  So, attached are two patches.
>
> 1. Fix for ExecInitPartitionInfo to use the right RT index to pass to
>    InitResultRelInfo
>
> 2. v5 of the patch to fix the bug of foreign partitions
>
> Thoughts?

Are you splitting this into 2 patches here because there are 2
separate issues?  If so, what are those issues?  There seem to be a
bunch of interrelated changes here but I haven't seen a clear
explanation of which ones are needed for which reasons.

I agree that fixing ExecInitPartitionInfo to use the right RT index in
the first place sounds like a better idea than trying to piece
together which RT index we should be using after-the-fact, but I need
to better understand what problems we're trying to fix here before I
can be sure if that's the strategy I want to endorse...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove now-unnecessary cast.

  2. Fix interaction of foreign tuple routing with remote triggers.