Re: pg_resetwal is broken if run from v10 against older version of PG data directory

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Simon Riggs <simon@2ndquadrant.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila16@gmail.com>, tushar <tushar.ahuja@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2017-05-30T11:43:18Z

Lists: pgsql-hackers

On Tue, May 30, 2017 at 4:24 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> Just check the name of the directory so that pg_resetwal will refuse
> to run against pg_xlog directory

That's a strictly weaker integrity check than what Tom already
committed.  That only distinguishes pre-10 from post-10, whereas Tom
linked it to the specific major version, which is better.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Prevent running pg_resetwal/pg_resetxlog against wrong-version data dirs.
- f3db7f164a29 10.0 landed
- 9ed68f64114e 9.4.13 landed
- 98bff290747e 9.6.4 landed
- 78e4fb8e41df 9.3.18 landed
- 6b48f06da85e 9.2.22 landed
- 5bcbc4cd6d9c 9.5.8 landed
Rename "pg_xlog" directory to "pg_wal".
- f82ec32ac30a 10.0 cited