Horton

Re: clog double-dip in heap_hot_search_buffer

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2012-05-02T16:07:55Z
Lists: pgsql-hackers 
On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
>
> s/alive/dead/ in that comment?

Yep, good catch, thanks.

> Otherwise this seems like a good idea.

Do you think I should apply this to 9.2, or wait until 9.3?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company