Horton

Re: On disable_cost

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, David Rowley <dgrowleyml@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <hlinnaka@iki.fi>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-07T15:36:07Z
Lists: pgsql-hackers 
On Mon, Oct 7, 2024 at 11:28 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2024-Oct-03, Robert Haas wrote:
> > One general thing to think about is that we really document very
> > little about EXPLAIN. That might not be good, but we should consider
> > whether it will look strange if we document a bunch of stuff about
> > this and still don't talk about anything else.
>
> I completely agree that we document very little about EXPLAIN.  However,
> I disagree that we should continue to do so.  I'd rather take the
> opportunity to _add_ more details that we currently omit, and make the
> documentation more complete.  A short blurb about Disabled Nodes such as
> the one Laurenz proposed seems an excellent way to start; we can add
> more later, as people propose them.  We don't have to stop here, and we
> don't have to stay at statu quo re. other points.

Sure, that all makes sense. I was just raising it as a point to consider.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Doc: add detail about EXPLAIN's "Disabled" property

  2. Adjust EXPLAIN's output for disabled nodes

  3. Fix order of parameters in a cost_sort call

  4. Show number of disabled nodes in EXPLAIN ANALYZE output.

  5. Treat number of disabled nodes in a path as a separate cost metric.

  6. Remove grotty use of disable_cost for TID scan plans.