Re: PG 10: could not generate random cancel key
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-17T17:31:01Z
Lists: pgsql-hackers
On Tue, Jul 17, 2018 at 1:27 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > On 2018-Jul-17, Robert Haas wrote: > >> On Tue, Jul 17, 2018 at 8:33 AM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote: >> > if (RAND_status() == 0) >> > RAND_poll(); >> >> Looks like a recipe for an infinite loop. At least, I think we ought >> to have a CHECK_FOR_INTERRUPTS() in that loop. > > What loop? Ugh, I'm not doing very well today, am I? I read that as while() but it says if(). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Guard against rare RAND_bytes() failures in pg_strong_random().
- 821200405cc3 10.5 landed
- 1f919e663ee2 11.0 landed
- 8f6ce7fb090a 12.0 landed