Horton

Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name

Yurii Rashkovskii <yrashk@gmail.com>

View thread View on postgr.es
From: Yurii Rashkovskii <yrashk@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-04-24T17:43:51Z
Lists: pgsql-hackers

Attachments

You're absolutely right. Here's v3.


On Mon, Apr 24, 2023 at 6:30 PM Aleksander Alekseev <
aleksander@timescale.com> wrote:

> Hi,
>
> > This is a very good catch and a suggestion. I've slightly reworked the
> patch, and I also made this static assertion to have less indirection and,
> therefore, make it easier to understand the premise.
> > Version 2 is attached.
>
> ```
> sizeof((BackgroundWorker *)NULL)->bgw_library_name
> ```
>
> I'm pretty confident something went wrong with the parentheses in v2.
>
>
> --
> Best regards,
> Aleksander Alekseev
>


-- 
Y.

Commits

  1. Increase size of bgw_library_name.