Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
Yurii Rashkovskii <yrashk@gmail.com>
From: Yurii Rashkovskii <yrashk@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Aleksander Alekseev <aleksander@timescale.com>,
pgsql-hackers@lists.postgresql.org
Date: 2023-07-02T23:37:52Z
Lists: pgsql-hackers
Hi Nathan, On Fri, Jun 30, 2023 at 2:39 PM Nathan Bossart <nathandbossart@gmail.com> wrote: > > In v4, I've introduced a new BGW_LIBLEN macro and set it to the default > value of MAXPGPATH (1024). This way, the value can live in bgworker.h like > the other BGW_* macros do. Plus, this should make the assertion that > checks for backward compatibility unnecessary. Since bgw_library_name is > essentially a path, I can see the argument that we should just set > BGW_LIBLEN to MAXPGPATH directly. I'm curious what folks think about this. > Thank you for revising the patch. While this is relatively minor, I think it should be set to MAXPGPATH directly to clarify their relationship. -- Y.
Commits
-
Increase size of bgw_library_name.
- 957845789bb9 17.0 landed