Re: tests fail on windows with default git settings
Dave Page <dpage@pgadmin.org>
From: Dave Page <dpage@pgadmin.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2024-07-24T15:49:28Z
Lists: pgsql-hackers
Hi On Sat, 13 Jul 2024 at 23:01, Thomas Munro <thomas.munro@gmail.com> wrote: > On Fri, Jul 12, 2024 at 3:49 AM Dave Page <dpage@pgadmin.org> wrote: > > So I received an off-list tip to checkout [1], a discussion around > GSSAPI causing test failures on windows that Alexander Lakhin was looking > at. Thomas Munro's v2 patch to try to address the issue brought me down to > just a single test failure with GSSAPI enabled on 17b2 (with a second, > simple fix for the OpenSSL/Kerberos/x509 issue): pg_dump/002_pg_dump. The > relevant section from the log looks like this: > > I pushed that (ba9fcac7). > > > [15:28:42.692](0.006s) not ok 2 - connecting to a non-existent database: > matches > > [15:28:42.693](0.001s) # Failed test 'connecting to a non-existent > database: matches' > > # at C:/Users/dpage/git/postgresql/src/bin/pg_dump/t/002_pg_dump.pl > line 4689. > > [15:28:42.694](0.001s) # 'pg_dump: error: connection > to server at "127.0.0.1", port 53834 failed: could not initiate GSSAPI > security context: No credentials were supplied, or the credentials were > unavailable or inaccessible: Credential cache is empty > > # connection to server at "127.0.0.1", port 53834 failed: FATAL: > database "qqq" does not exist > > # ' > > # doesn't match '(?^:pg_dump: error: connection to server .* failed: > FATAL: database "qqq" does not exist)' > > Does it help if you revert 29992a6? > Sorry for the delay - things got crazy busy for a while. No, reverting that commit does not help. -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
Commits
-
Use diff --strip-trailing-cr in pg_regress.c
- 291c42074721 18.0 landed
-
Use diff's --strip-trailing-cr flag where appropriate on Windows
- 4506d18a9891 17.0 landed
- 628c1d1f2c82 18.0 landed