Horton

Re: moving extraUpdatedCols out of RangeTblEntry (into ModifyTable)

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2022-12-07T11:57:09Z
Lists: pgsql-hackers 
On Wed, Dec 7, 2022 at 8:54 PM Amit Langote <amitlangote09@gmail.com> wrote:
> Per Alvaro's advice, forking this from [1].
>
> In that thread, Tom had asked if it wouldn't be better to find a new
> place to put extraUpdatedCols [2] instead of RangeTblEntry, along with
> the permission-checking fields are now no longer stored in
> RangeTblEntry.
>
> In [3] of the same thread, I proposed to move it into a List of
> Bitmapsets in ModifyTable, as implemented in the attached patch that I
> had been posting to that thread.
>
> The latest version of that patch is attached herewith.  I'll add this
> one to the January CF too.

Done.

https://commitfest.postgresql.org/41/4049/

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

Commits

  1. Fix calculation of which GENERATED columns need to be updated.

  2. Push lpp variable closer to usage in heapgetpage()