Horton

Thread

Commits

  1. Doc: Fix example related to partition pruning

  1. Fix example in partitioning documentation

    Amit Langote <amitlangote09@gmail.com> — 2019-09-24T01:52:30Z

    Hi,

As of v12, Append node is elided when there's a single subnode under
it.  An example in the partitioning documentation needs to be fixed to
account for that change.  Attached a patch.

Thanks,
Amit

  2. Re: Fix example in partitioning documentation

    Michael Paquier <michael@paquier.xyz> — 2019-09-24T02:14:42Z

    On Tue, Sep 24, 2019 at 10:52:30AM +0900, Amit Langote wrote:
> As of v12, Append node is elided when there's a single subnode under
> it.  An example in the partitioning documentation needs to be fixed to
> account for that change.  Attached a patch.

Indeed, using the same example as the docs:
CREATE TABLE measurement (
     logdate         date not null,
     peaktemp        int,
     unitsales       int
 ) PARTITION BY RANGE (logdate);
CREATE TABLE measurement_y2016m07
     PARTITION OF measurement (
     unitsales DEFAULT 0
 ) FOR VALUES FROM ('2016-07-01') TO ('2016-08-01');
SET enable_partition_pruning = on;
EXPLAIN SELECT count(*) FROM measurement WHERE logdate = DATE
'2016-07-02';

I'll take care of committing that, however this will have to wait
until v12 RC1 is tagged.
--
Michael

  3. Re: Fix example in partitioning documentation

    Amit Langote <amitlangote09@gmail.com> — 2019-09-24T02:36:40Z

    On Tue, Sep 24, 2019 at 11:14 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Sep 24, 2019 at 10:52:30AM +0900, Amit Langote wrote:
> > As of v12, Append node is elided when there's a single subnode under
> > it.  An example in the partitioning documentation needs to be fixed to
> > account for that change.  Attached a patch.
>
> Indeed, using the same example as the docs:
> CREATE TABLE measurement (
>      logdate         date not null,
>      peaktemp        int,
>      unitsales       int
>  ) PARTITION BY RANGE (logdate);
> CREATE TABLE measurement_y2016m07
>      PARTITION OF measurement (
>      unitsales DEFAULT 0
>  ) FOR VALUES FROM ('2016-07-01') TO ('2016-08-01');
> SET enable_partition_pruning = on;
> EXPLAIN SELECT count(*) FROM measurement WHERE logdate = DATE
> '2016-07-02';
>
> I'll take care of committing that, however this will have to wait
> until v12 RC1 is tagged.

Sure, thank you.

Regards,
Amit

  4. Re: Fix example in partitioning documentation

    Michael Paquier <michael@paquier.xyz> — 2019-09-25T04:47:27Z

    On Tue, Sep 24, 2019 at 11:36:40AM +0900, Amit Langote wrote:
> Sure, thank you.

And done with f5daf7f, back-patched down to 12.
--
Michael

  5. Re: Fix example in partitioning documentation

    Amit Langote <amitlangote09@gmail.com> — 2019-09-25T05:36:41Z

    On Wed, Sep 25, 2019 at 1:47 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Sep 24, 2019 at 11:36:40AM +0900, Amit Langote wrote:
> > Sure, thank you.
>
> And done with f5daf7f, back-patched down to 12.

Thanks again. :)

Regards,
Amit