Horton

Re: Report error position in partition bound check

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Alexandra Wang <lewang@pivotal.io>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Ashwin Agrawal <aagrawal@pivotal.io>, Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>
Date: 2020-04-09T14:08:36Z
Lists: pgsql-hackers 
On Thu, Apr 9, 2020 at 10:51 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> Hi Alexandra,
> As Michael said it will be considered for the next commitfest. But
> from a quick glance, a suggestion.
> Instead of passing NULL parsestate from ATExecAttachPartition, pass
> make_parsestate(NULL). parse_errorposition() takes care of NULL parse
> state input, but it might be safer this way. Better if we could cook
> up a parse state with the query text available in
> AlterTableUtilityContext available in ATExecCmd().

+1.  Maybe pass the *context* down to ATExecAttachPartition() from
ATExecCmd() rather than a ParseState.

-- 

Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Improve error cursor positions for problems with partition bounds.