Horton
Menu

Re: Eliminating SPI / SQL from some RI triggers - take 3

amit <amitlangote09@gmail.com>

View thread
From: Amit Langote <amitlangote09@gmail.com>
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Haibo Yan <tristan.yim@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas@vondra.me>
Date: 2026-04-01T09:51:10Z
Lists: pgsql-hackers

Attachments

On Wed, Apr 1, 2026 at 5:51 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Wed, Apr 1, 2026 at 12:54 AM Junwang Zhao <zhjwpku@gmail.com> wrote:
> > +       if (riinfo->fpmeta == NULL)
> > +       {
> > +               /* Reload to ensure it's valid. */
> > +               riinfo = ri_LoadConstraintInfo(riinfo->constraint_id);
> >
> > I was thinking of wrapping the reload in a conditional check like
> > `!riinfo->valid`, since `riinfo` can be valid even when `fpmeta == NULL`.
> > However,  `if (riinfo->fpmeta == NULL)` should rarely be true, so the
> > unconditional reload is harmless, and the code is cleaner.
> >
> > +1 to the fix.
>
> Thanks for checking.
>
> I have just pushed a slightly modified version of that.
>
> > > 0002 is the rebased batching patch.
> >
> > The change of RI_FastPathEntry from storing riinfo to fk_relid
> > makes sense to me. I'll do another review on 0002 tomorrow.
>
> Here's another version.
>
> This time, I have another fixup patch (0001) to make FastPathMeta
> self-contained by copying the FmgrInfo structs it needs out of
> RI_CompareHashEntry rather than storing pointers into it.  This avoids
> any dependency on those cache entries remaining stable.  I'll push
> that once the just committed patch has seen enough BF animals.

Pushed.

> 0002 is rebased over that.

Rebased again.

-- 
Thanks, Amit Langote

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some const qualifier use in ri_triggers.c

  2. doc: Improve consistency of parallel vacuum description.

  3. Move afterTriggerFiringDepth into AfterTriggersData

  4. Fix typo left by 34a30786293

  5. Fix RI fast-path crash under nested C-level SPI

  6. Add nkeys parameter to recheck_matched_pk_tuple()

  7. Fix deferred FK check batching introduced by commit b7b27eb41a5

  8. Optimize fast-path FK checks with batched index probes

  9. Make FastPathMeta self-contained by copying FmgrInfo structs

  10. Add fast path for foreign key constraint checks