Horton

Re: BUG #16293: postgres segfaults and returns SQLSTATE 08006

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel WM <dwilches@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2020-03-31T09:37:56Z
Lists: pgsql-bugs

Attachments

On Tue, Mar 31, 2020 at 3:30 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Tue, Mar 24, 2020 at 3:53 AM Andres Freund <andres@anarazel.de> wrote:
> > If we actually want to keep this conversion, I wonder if the right
> > answer would be to change those routines to pass in
> > mtstate->mt_root_tuple_slot instead (and ensure it's created when
> > needed). One way to achieve that would be to move
> > ModifyTableState->mt_root_tuple_slot to ResultRelInfo - and potentially
> > create it on demand?
>
> Something like ri_PartitionRootSlot sounds like a good idea, but we
> should make that a reference to mt_root_tuple_slot instead of its
> replacement.  Would you be interested in seeing a patch?

I have updated the patch for HEAD to be this way.

-- 
Thank you,

Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Add regression tests for constraint errors in partitioned tables.

  2. Fix potential crash after constraint violation errors in partitioned tables.