Horton

Re: pgsql: Add more SQL/JSON constructor functions

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: jian he <jian.universality@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-09-06T08:01:40Z
Lists: pgsql-hackers

Attachments

On Fri, Sep 6, 2024 at 1:34 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Fri, Sep 6, 2024 at 12:07 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > On Thu, Sep 5, 2024 at 9:58 PM Amit Langote <amitlangote09@gmail.com> wr
> > Pushed.
>
> Reverted 0002-0004 from both master and REL_17_STABLE due to BF failures.
>
> 0002-0003 are easily fixed by changing the newly added tests to not
> use EXPLAIN VERBOSE to test deparsing related changes, so will re-push
> those shortly.

Done.

> 0004 perhaps doesn't play nicely with LLVM compilation but I don't yet
> understand why.

Attached is an updated patch that takes care of the issue.  The bug
was that llvm_compile_expr() didn't like that jump_error, jump_empty,
and jump_end could all point to the same step.  In the attached,
jump_empty / jump_error are left to be -1 if ON ERROR, ON EMPTY steps
are not added, instead of making them also point to the step address
that jump_end points to.  ExecEvalJsonExprPath() are also updated to
check if jump_error or jump_empty is -1 and return jump_end if so.

-- 
Thanks, Amit Langote

Commits

  1. SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY steps

  2. SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE

  3. SQL/JSON: Fix JSON_TABLE() column deparsing

  4. Update comment about ExprState.escontext

  5. SQL/JSON: Fix casting for integer EXISTS columns in JSON_TABLE

  6. SQL/JSON: Some fixes to JsonBehavior expression casting

  7. SQL/JSON: Remove useless code in ExecInitJsonExpr()

  8. SQL/JSON: Respect OMIT QUOTES when RETURNING domains over jsonb

  9. SQL/JSON: Improve error-handling of JsonBehavior expressions

  10. SQL/JSON: Fix error-handling of some JsonBehavior expressions

  11. SQL/JSON: Rethink c2d93c3802b

  12. SQL/JSON: Always coerce JsonExpr result at runtime

  13. SQL/JSON: Fix coercion of constructor outputs to types with typmod