Horton

Re: Allow batched insert during cross-partition updates

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>, gkokolatos@pm.me, PostgreSQL-development <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>, "Tsunakawa, Takayuki" <tsunakawa.takay@fujitsu.com>
Date: 2021-04-07T01:49:35Z
Lists: pgsql-hackers 
On Tue, Apr 6, 2021 at 10:52 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Tue, Apr 6, 2021 at 6:37 PM Amit Langote <amitlangote09@gmail.com> wrote:
> > > 3) will the cmin in the output always be the same?
> > > +SELECT cmin, * FROM batch_cp_upd_test3;
> >
> > TBH, I am not so sure.  Maybe it's not a good idea to rely on cmin
> > after all.  I've rewritten the tests to use a different method of
> > determining if a single or multiple insert commands were used in
> > moving rows into foreign partitions.
>
> Thanks! It looks good!

Thanks for checking.  I'll mark this as RfC.

-- 
Amit Langote
EDB: http://www.enterprisedb.com

Commits

  1. Allow batching of inserts during cross-partition updates.

  2. Fix handling of pending inserts in nodeModifyTable.c.

  3. Postpone some stuff out of ExecInitModifyTable.

  4. Fix tuple routing to initialize batching only for inserts