Horton

Re: Forget close an open relation in ReorderBufferProcessTXN()

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Japin Li <japinli@hotmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-01T12:04:38Z
Lists: pgsql-hackers 
On Tue, Jun 1, 2021 at 6:56 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Mon, May 31, 2021 at 8:51 AM Amit Langote <amitlangote09@gmail.com> wrote:
> > On Thu, May 27, 2021 at 3:36 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > Why do we need to move send_relation_and_attrs() call? I think it
> > > doesn't matter much either way but OTOH, in the existing code, if
> > > there is an error (say 'out of memory' or some other) while building
> > > the map, we won't send relation attrs whereas with your change we will
> > > unnecessarily send those in such a case.
> >
> > That's a good point.  I've reverted that change in the attached.
>
> Pushed.

Thank you.

-- 
Amit Langote
EDB: http://www.enterprisedb.com

Commits

  1. pgoutput: Fix memory leak due to RelationSyncEntry.map.