Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT
Amit Langote <amitlangote09@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Jeevan Ladhe <jeevanladhe.os@gmail.com>
Date: 2022-06-02T11:10:40Z
Lists: pgsql-hackers
On Thu, Jun 2, 2022 at 6:14 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > On Thu, Jun 2, 2022 at 10:23 AM Amit Langote <amitlangote09@gmail.com> wrote: > > On Wed, Jun 1, 2022 at 6:15 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote: > > > On Tue, May 31, 2022 at 9:35 PM Robert Haas <robertmhaas@gmail.com> wrote: > > > > I would probably just update the synopsis. It's not very hard to > > > > figure out what's likely to happen even without clicking through the > > > > link, so it seems like it's just being long-winded to duplicate the > > > > stuff here. But I don't care much if you feel otherwise. > > > > > > It looks like there are pros and cons. I think it’s a matter of > > > preference, though. > > > > > > I thought it would be an improvement, but I agree that we can live > > > without it, so I changed my mind; I'll go with my version. I think we > > > could revisit this later. > > > > I guess I'm fine with leaving the text as-is, though slightly bothered > > by leaving the phrase "partition of the given parent table with > > specified partition bound values" to also cover the DEFAULT partition > > case. > > I think we should discuss this separately, maybe as a HEAD-only patch, > so I pushed my version, leaving the description as-is. No problem, thanks for the fix. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
Commits
-
Doc: Further fix CREATE FOREIGN TABLE synopsis.
- cc75ad780d53 11.17 landed
- dadee8753936 12.12 landed
- de61a9cbaa95 13.8 landed
- 18e3b197bc6a 14.4 landed
- 642e9165fd51 15.0 landed
-
In CREATE FOREIGN TABLE syntax synopsis, fix partitioning stuff.
- d605eba0904b 10.22 landed
- 0fab33916789 11.17 landed
- 4368ef218959 12.12 landed
- 036cffbcae9b 13.8 landed
- a5fc06bf3135 14.4 landed
- ce21a36cf837 15.0 landed