Horton

Re: Question about duplicate JSONTYPE_JSON check

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Álvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tender Wang <tndrwang@gmail.com>, Maciek Sakrejda <maciek@pganalyze.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-13T03:51:43Z
Lists: pgsql-hackers 
On Wed, Mar 12, 2025 at 21:40 Álvaro Herrera <alvherre@alvh.no-ip.org>
wrote:

> On 2025-Mar-12, Amit Langote wrote:
>
> > Patch look good for committing?
>
> Ah sorry, I should have said so -- yes, it looks good to me.


Thanks (Maciek, Tender too) for the review.

  I feel a
> slight dislike for using URL-escaped characters in the mailing list link
> you added, because it means I cannot directly copy/paste the message-id
> string into my email client program.  Not a huge issue for sure, and it
> seems a majority of links in the source tree are already like that
> anyway, but this seems an inclusive, safe, welcoming nitpicking space :-)


Ah, no problem, fixed it. I prefer to see URLs in that way too, but somehow
didn’t notice what I had done.

Commits

  1. Fix copy-paste error in datum_to_jsonb_internal()

  2. Unify JSON categorize type API and export for external use