Horton
Menu

Re: BUG #18830: ExecInitMerge Segfault on MERGE

amit <amitlangote09@gmail.com>

View thread
From: Amit Langote <amitlangote09@gmail.com>
To: Tender Wang <tndrwang@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, David Rowley <dgrowleyml@gmail.com>, pgsql-bugs@lists.postgresql.org, tharakan@gmail.com
Date: 2025-03-13T12:44:44Z
Lists: pgsql-bugs 
On Thu, Mar 13, 2025 at 4:29 PM Tender Wang <tndrwang@gmail.com> wrote:
> Dean Rasheed <dean.a.rasheed@gmail.com> 于2025年3月13日周四 03:23写道：
>> It does mean that ExecGetRangeTableRelation() needs to allow pruned
>> relations to be opened, if called from ExecInitResultRelation(). I
>> think that's OK because the check for opening pruned relations still
>> applies to scan relations.
>
> A comment in execPartition.h may need to be changed:
> * partrel                                         Partitioned table Relation; obtained by
> *                                                     ExecGetRangeTableRelation(estate, rti), where
>
> Because the func interface has changed, the above comments are better to be changed "ExecGetRangeTableRelation(estate, rti, false)".

Noted, thanks.

-- 
Thanks, Amit Langote

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Ensure first ModifyTable rel initialized if all are pruned

  2. Don't lock partitions pruned by initial pruning

  3. Fix an oversight in cbc127917 to handle MERGE correctly

  4. Remove some unnecessary fields from Plan trees.