Horton

Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-02-06T02:07:22Z
Lists: pgsql-hackers 
On Thu, Feb 6, 2020 at 9:51 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> > On Wed, Feb 5, 2020 at 18:25 Amit Langote <amitlangote09@gmail.com> wrote:
> > > So, maybe you're saying that "waiting for checkpoint" is ambiguous and
> > > most people will assume it means "...to start".  As for me, I assume
> > > it ends with "...to finish".
>
> I'm not sure "most peple will assume" or not, so I said "I'm not
> sure".  For example, I feel strangeness to use "I'm waiting for Amit"
> to express that I'm waiting Amit to leave there.  That phrase gives me
> such kind of uneasiness.
>
> I thought of "establishing checkpoint" or "running a checkpoint" as
> other candidates.

Okay, I understand.  I am fine with "running checkpoint", although I
think "waiting for checkpoint" isn't totally wrong either.

Thanks,
Amit

Commits

  1. Report NULL as total backup size if it's not estimated.

  2. Make pg_basebackup ask the server to estimate the total backup size, by default.

  3. Report progress of streaming base backup.