Horton

Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-23T05:05:59Z
Lists: pgsql-hackers 
On Sun, May 23, 2021 at 10:28 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
> > ... wrong.  Running v13 branch tip under CLOBBER_CACHE_ALWAYS provokes
> > a core dump in 013_partition.pl, so 1375422c is not to blame.  Now
> > I'm wondering how far back there's a live issue.
>
> Oh, of course, it's directly the fault of the patch that added support
> for partitioned target tables.

Yeah, the problem seems to affect only partition child tables, so yeah
this problem started with f1ac27bfda6.

> I concluded that a verbatim backpatch wasn't too suitable because
> a04daa97a had changed a lot of the APIs here.  So I left the APIs
> for the xxx_internal() functions alone.  Otherwise the patch
> pretty much works as-is in v13.

That looks reasonable.

Thanks.

-- 
Amit Langote
EDB: http://www.enterprisedb.com

Commits

  1. Be more verbose when the postmaster unexpectedly quits.

  2. Fix access to no-longer-open relcache entry in logical-rep worker.