Re: Fix a typo in rewriteHandler.c
Amit Langote <amitlangote09@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
To: "Sho Kato (Fujitsu)" <kato-sho@fujitsu.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-06-16T01:25:13Z
Lists: pgsql-hackers
Hello,
On Thu, Jun 15, 2023 at 5:07 PM Sho Kato (Fujitsu) <kato-sho@fujitsu.com> wrote:
>
> Hi,
>
> I've attached the patch for the following rewriteTargetView comments.
>
>
> Assert(parsetree->resultRelation == new_rt_index);
>
> /*
> * For INSERT/UPDATE we must also update resnos in the targetlist to refer
> * to columns of the base relation, since those indicate the target
> * columns to be affected.
> *
> * Note that this destroys the resno ordering of the targetlist, but that
> * will be fixed when we recurse through rewriteQuery, which will invoke
> * rewriteTargetListIU again on the updated targetlist.
> */
> if (parsetree->commandType != CMD_DELETE)
> {
> foreach(lc, parsetree->targetList)
>
> s/rewriteQuery/RewriteQuery
Good catch and thanks for the patch. Will push shortly.
--
Thanks, Amit Langote
EDB: http://www.enterprisedb.com
Commits
-
Fix typo in comment.
- b103d616caeb 11.21 landed
- 2f6e826f6579 12.16 landed
- d5300bc79dff 13.12 landed
- 3f157d085bd7 14.9 landed
- 35470357ee4c 15.4 landed
- 160c23b5fa02 16.0 landed