Re: enable/disable broken for statement triggers on partitioned tables
Amit Langote <amitlangote09@gmail.com>
From: Amit Langote <amitlangote09@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Simon Riggs <simon.riggs@enterprisedb.com>
Date: 2022-08-04T13:21:31Z
Lists: pgsql-hackers
On Thu, Aug 4, 2022 at 9:56 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > Another point for backpatch: EnableDisableTrigger() changes API, which > is potentially not good. In backbranches I'll keep the function > unchanged and add another function with the added argument, > EnableDisableTriggerNew(). +1 > So extensions that want to be compatible with both old and current > versions (assuming any users of that function exist out of core; I > didn't find any) could do something like > > #if PG_VERSION_NUM <= 160000 > EnableDisableTriggerNew( all args ) > #else > EnableDisableTrigger( all args ) > #endif > > and otherwise they're compatible as compiled today. > > Since there are no known users of this interface, it doesn't seem to > warrant any more convenient treatment. Makes sense. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
Commits
-
Fix ENABLE/DISABLE TRIGGER to handle recursion correctly
- ec0925c22a3d 16.0 landed
- e78fd9084587 15.0 landed
- 731d514ae58f 14.5 landed
- ab855663012c 13.8 landed
- 6e7b37264e96 12.12 landed
- ce8e066521d1 11.17 landed