Horton

Re: BEFORE UPDATE trigger on postgres_fdw table not work

Amit Langote <amitlangote09@gmail.com>

View thread View on postgr.es
From: Amit Langote <amitlangote09@gmail.com>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Tom Lane <tgl@sss.pgh.pa.us>, Shohei Mochizuki <shohei.mochizuki@toshiba.co.jp>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-06-12T06:33:35Z
Lists: pgsql-hackers 
Fujita-san,

On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> I did that, but couldn't find any issue about the patch.  Here is an
> updated version of the patch.

Thanks for the updating the patch.

>  Changes are:
>
> * Reworded the comments a bit in postgresPlanFoereignModify the
> original patch modified

+     * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
+     * triggers might change values for non-target columns, in which case we

First line seems to be missing a word or two.  Maybe:

+     * statement, and for UPDATE if there are BEFORE ROW UPDATE triggers,
+     * since those triggers might change values for non-target columns, in

Thanks,
Amit

Commits

  1. postgres_fdw: Account for triggers in non-direct remote UPDATE planning.

  2. Offer triggers on foreign tables.