Re: SQL/JSON revisited

Amit Langote <amitlangote09@gmail.com>

From: Amit Langote <amitlangote09@gmail.com>

To: Erik Rijkers <er@xs4all.nl>

Cc: vignesh C <vignesh21@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Andrew Dunstan <andrew@dunslane.net>, e.indrupskaya@postgrespro.ru

Date: 2023-02-21T03:09:15Z

Lists: pgsql-hackers

Attachments

v5-0007-PLAN-clauses-for-JSON_TABLE.patch (application/octet-stream) patch v5-0007
v5-0009-Claim-SQL-standard-compliance-for-SQL-JSON-featur.patch (application/octet-stream) patch v5-0009
v5-0010-Proposed-reworking-of-SQL-JSON-documentaion.patch (application/octet-stream) patch v5-0010
v5-0008-Documentation-for-SQL-JSON-features.patch (application/octet-stream) patch v5-0008
v5-0006-JSON_TABLE.patch (application/octet-stream) patch v5-0006
v5-0005-RETURNING-clause-for-JSON-and-JSON_SCALAR.patch (application/octet-stream) patch v5-0005
v5-0002-IS-JSON-predicate.patch (application/octet-stream) patch v5-0002
v5-0003-SQL-JSON-query-functions.patch (application/octet-stream) patch v5-0003
v5-0004-SQL-JSON-functions.patch (application/octet-stream) patch v5-0004
v5-0001-SQL-JSON-constructors.patch (application/octet-stream) patch v5-0001

On Mon, Feb 20, 2023 at 11:41 PM Erik Rijkers <er@xs4all.nl> wrote:
> Op 20-02-2023 om 08:35 schreef Amit Langote:
> > Rebased again over queryjumble overhaul.
> But the following statement is a problem. It does not crash but it goes
> off, half-freezing the machine, and only comes back after fanatic
> Ctrl-C'ing.
>
> select json_query(jsonb '[3,4]', '$[*]' returning bigint[] empty object
> on error);
>
> Can you have a look?

Thanks for the test case.  It caused ExecInterpExpr() to enter an
infinite loop, which I've fixed in the attached updated version.  I've
also merged Elena's documentation changes; I can see that
<replaceable> is more correct.

Now looking at Andres' comments, though, posting a version containing
a fix for the above case so Erik may continue the testing in the
meantime.

-- 
Thanks, Amit Langote
EDB: http://www.enterprisedb.com

Commits

Add SQL/JSON query functions
- 6185c9737cf4 17.0 landed
Add soft error handling to some expression nodes
- aaaf9449ec6b 17.0 landed
Adjust populate_record_field() to handle errors softly
- 1edb3b491bee 17.0 landed
Refactor code used by jsonpath executor to fetch variables
- faa2b953ba3b 17.0 landed
Code review for recent SQL/JSON commits
- 71bfd1543f8b 16.0 landed
Fix inconsistencies and style issues in new SQL/JSON code
- 60966f56c3e4 16.0 landed
Don't install postmaster symlink anymore
- 37e267335068 16.0 cited
Revert SQL/JSON features
- 2f2b18bd3f55 16.0 cited
Doc: standardize markup a bit more.
- 47046763c3ed 13.0 cited